Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use role grycap.htcondor from usegalaxy-eu organization #1234

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Use role grycap.htcondor from usegalaxy-eu organization #1234

merged 1 commit into from
Aug 2, 2024

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Jun 14, 2024 •
edited
Loading

As part of the migration to HTCondor 23, the role managing HTCondor was switched from usegalaxy_eu.htcondor to grycap.htcondor. I forked it and added linting and a couple of tests on top, and that fork is what useGalaxy.eu is running today.

However, the entry for grycap.htcondor in requirements.yaml still points to that fork https://github.com/kysrpex/grycap-ansible-role-htcondor on my personal account. This is wrong for many reasons.

This commit changes the source URL of the role to a fork on the usegalaxy-eu organization.

Useful information from the GitHub docs: What happens to forks when a repository is deleted or changes visibility?

@kysrpex
Use role grycap.htcondor from usegalaxy-eu organization
8e72e55 
As part of the migration to HTCondor 23, the role managing HTCondor was switched from `usegalaxy_eu.htcondor` to `grycap.htcondor`. I forked it and added linting and a couple of tests on top, and that fork is what useGalaxy.eu is running today.

However, the entry for `grycap.htcondor` in requirements.yaml still points to that fork https://github.com/kysrpex/grycap-ansible-role-htcondor on my personal account. This is wrong for many reasons.

This commit changes the source URL of the role to a fork on the usegalaxy-eu organization.
@kysrpex kysrpex added the bug label Jun 14, 2024
@kysrpex kysrpex requested a review from sanjaysrikakulam June 14, 2024 14:01
@kysrpex kysrpex mentioned this pull request Jun 25, 2024
Open
@mira-miracoli
Copy link
Contributor

Thanks, I guess we should activate the workflows in the repo?
Also a question; the upstream repo is now your repo, but would it make sense to set the original https://github.com/grycap/ansible-role-htcondor repo as upstream?

@kysrpex
Copy link
Contributor Author

kysrpex commented Jun 28, 2024

Thanks, I guess we should activate the workflows in the repo? Also a question; the upstream repo is now your repo, but would it make sense to set the original https://github.com/grycap/ansible-role-htcondor repo as upstream?

Thanks, I just activated the workflows. It would make a lot of sense. I am betting that when I delete my repository, the fork on usegalaxy-eu will switch to the upstream automatically (see GitHub docs)

When you delete a public repository, one of the existing public forks is chosen to be the new upstream repository. All other repositories are forked off of this new upstream and subsequent pull requests go to this new upstream repository.

It is a "bet" because they do not specify which public fork becomes the upstream. It may as well be a random one. Do you know if the upstream of a fork on GitHub can be changed manually? If not we can first gamble and if we're unlucky then investigate?

@kysrpex kysrpex merged commit e55d5f2 into master Aug 2, 2024
2 checks passed
@kysrpex kysrpex deleted the ansible-htcondor-grycap_from_usegalaxy-eu branch August 2, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaysrikakulam sanjaysrikakulam Awaiting requested review from sanjaysrikakulam

Assignees

@sanjaysrikakulam sanjaysrikakulam

@kysrpex kysrpex

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kysrpex @mira-miracoli @sanjaysrikakulam